Skip to content

Conversation

@isegall-da
Copy link
Contributor

@isegall-da isegall-da commented Jan 21, 2026

Fixes https://github.com/DACH-NY/cn-test-failures/issues/6698

I actually disagree with @nicu-da .
The contract that fails this check is a leftover from a previous test, and AFAICT the only reason we're waiting for it to not exist is to not pollute this test. It eventually does get collected by a purchase-traffic automation, but that's not of interest to this test. I therefore propose to just not wait for that at all, and handle the existence of such contracts in the test.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Copy link
Contributor

@nicu-da nicu-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da enabled auto-merge (squash) January 21, 2026 19:31
@isegall-da isegall-da merged commit fb140ba into main Jan 21, 2026
62 checks passed
@isegall-da isegall-da deleted the isegall/app-rewards-flake branch January 21, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants